-
Notifications
You must be signed in to change notification settings - Fork 559
Dashboard: Remove chakra provider from team/settings/notifications page #7479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Remove chakra provider from team/settings/notifications page #7479
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7479 +/- ##
=======================================
Coverage 51.92% 51.92%
=======================================
Files 949 949
Lines 64148 64148
Branches 4229 4229
=======================================
Hits 33311 33311
Misses 30731 30731
Partials 106 106
🚀 New features to boost your workflow:
|
size-limit report 📦
|
6851b9a
to
1ec9c34
Compare
320d192
to
22ba0cb
Compare
1ec9c34
to
8b95725
Compare
22ba0cb
to
7b7aa1f
Compare
Merge activity
|
…ge (#7479) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the notifications settings page by renaming components, updating the layout, and improving the user interface for managing notifications. ### Detailed summary - Deleted `SettingsNotificationsPage` and replaced it with `Notifications`. - Updated the main page layout to include a header and description for notifications. - Enhanced the `Notifications` component with a new background and border styling. - Added a separator line in the `Notifications` component. - Removed unnecessary wrapper from `SettingSwitch` layout. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
8b95725
to
1c638ed
Compare
7b7aa1f
to
c356813
Compare
PR-Codex overview
This PR focuses on refactoring the notifications settings in the team management section of the app. It replaces the
SettingsNotificationsPage
with a newNotifications
component and updates the UI for better clarity and organization.Detailed summary
NotificationsPage.tsx
.page.tsx
to importNotifications
instead ofSettingsNotificationsPage
.page.tsx
with a new header and description for notifications.Notifications.tsx
to include additional styling.Notifications.tsx
.