-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epa justice demographics #667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested everything mentioned in the PR description + a couple more locations and areas that do not have census data, just to make sure everything works as expected there too. Everything looks & acts great from the coding perspective!
I've added a handful of PR code comments with minor text suggestions to add missing words (to make things more grammatically consistent with the rest of the report page), and also to remove some redundant text in demographics.json
, which you may or may not agree with, but makes more sense to me.
Co-authored-by: Craig Stephenson <[email protected]>
Co-authored-by: Craig Stephenson <[email protected]>
Co-authored-by: Craig Stephenson <[email protected]>
Co-authored-by: Craig Stephenson <[email protected]>
Co-authored-by: Craig Stephenson <[email protected]>
Co-authored-by: Craig Stephenson <[email protected]>
Co-authored-by: Craig Stephenson <[email protected]>
This reverts commit d5b3b59.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-reviewed this PR by testing about 10 locations, including heavy hitters like Anchorage, Fairbanks, and Juneau as well as smaller places like Delta Junction, Bethel, Nome, and Utqiaġvik. I also tested a couple places in Canada, and an area report to see what would happen.
Everything looks great except for a couple small things that I'm not sure are within the scope of this PR or not. If not, we can make tickets for these and tackle them later.
-
There are some character encoding issues for the Utqiaġvik report. Utqiaġvik is rendered correctly elsewhere on the page, but it looks like the bits of text received from the GeoServer demographics data needs some help before being displayed.
-
I tried loading the NCR report for Fairbanks North Star Borough and noticed that it does not have any demographics data even though, if you search for Fairbanks, it loads & displays the data for the Fairbanks North Star Borough. Not sure if this is intentional, but seems like it would bit a fair bit of work to solve, so probably best to be tackled later?
Josh got a ticket to track down the source of the ? in Utqiagvik but happily it's only that one place. Ticket added for addressing the boroughs situation. |
Adds demographics report section! 🎺
For local setup for testing, check out the data-api repo at this commit (or newer).
Things to test:
If no demographic data are present, there should be a notice to the user to that effect with a "get in touch if you have questions."