Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented enumerate for iterator types #56

Merged
merged 9 commits into from
Mar 4, 2025
Merged

Implemented enumerate for iterator types #56

merged 9 commits into from
Mar 4, 2025

Conversation

jojongx
Copy link
Contributor

@jojongx jojongx commented Feb 9, 2025

Added mil_tools/src/itertools.cpp & mil_tools/include/mil_tools/itertools.hpp + edited CMakeLists.txt accordingly. Implemented enumerate helper function for c++.

@cbrxyz
Copy link
Member

cbrxyz commented Feb 9, 2025

Please add some test cases, fix the build issues, and once ready, request my review.

@cbrxyz cbrxyz marked this pull request as draft February 12, 2025 21:07
@jojongx
Copy link
Contributor Author

jojongx commented Feb 17, 2025

This week I worked on resolving my build issues and creating valid test cases for the enumerate function. I read up on gtest and cmake documentation, especially learning about the proper/valid implementation of the CMakeLists.txt file and applying this to the mil_tools part of the repo. There are still compatibility issues with the function mainly regarding linking issues with cmake. I keep getting an error that my enumerate header is not found despite seemingly correct directory structure and similarities with the strings.hpp/strings.cpp files (parallel files to itertools). I will keep working to diagnose any further problems and hopefully resolve them. My commits are not pushed back to this branch yet.

@jojongx jojongx marked this pull request as ready for review February 26, 2025 03:06
@jojongx
Copy link
Contributor Author

jojongx commented Feb 26, 2025

Resolved build issues and reorganized files (realized templates should be in the header.hpp). Requesting review

@jojongx jojongx requested a review from cbrxyz February 26, 2025 03:21
@jojongx
Copy link
Contributor Author

jojongx commented Mar 3, 2025

I resolved all build issues and scripts work from my local host. Test files claim their respective .hpp files are not found when in vs code but it does not impact compiling and goes away when I reopen the editor. All gtest test cases pass and awaiting approval. In the later half of the week I began looking into issue #73. As of right now I understand the different shell files and with guidance from @cdurkin35 I will continue working on a solution.

Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you joseph!

@cbrxyz cbrxyz merged commit 48933ff into main Mar 4, 2025
3 checks passed
@cbrxyz cbrxyz deleted the joseph-enumerate branch March 4, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants