-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented enumerate for iterator types #56
Conversation
Please add some test cases, fix the build issues, and once ready, request my review. |
This week I worked on resolving my build issues and creating valid test cases for the enumerate function. I read up on gtest and cmake documentation, especially learning about the proper/valid implementation of the CMakeLists.txt file and applying this to the mil_tools part of the repo. There are still compatibility issues with the function mainly regarding linking issues with cmake. I keep getting an error that my enumerate header is not found despite seemingly correct directory structure and similarities with the strings.hpp/strings.cpp files (parallel files to itertools). I will keep working to diagnose any further problems and hopefully resolve them. My commits are not pushed back to this branch yet. |
Resolved build issues and reorganized files (realized templates should be in the header.hpp). Requesting review |
I resolved all build issues and scripts work from my local host. Test files claim their respective .hpp files are not found when in vs code but it does not impact compiling and goes away when I reopen the editor. All gtest test cases pass and awaiting approval. In the later half of the week I began looking into issue #73. As of right now I understand the different shell files and with guidance from @cdurkin35 I will continue working on a solution. |
…t copies, add test of enumerate with noncopyable types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you joseph!
Added mil_tools/src/itertools.cpp & mil_tools/include/mil_tools/itertools.hpp + edited CMakeLists.txt accordingly. Implemented enumerate helper function for c++.