Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader-program abstraction #20

Open
3 tasks
wpumacay opened this issue May 24, 2023 · 0 comments
Open
3 tasks

Shader-program abstraction #20

wpumacay opened this issue May 24, 2023 · 0 comments
Assignees
Labels
component: assets Related to assets management (e.g. Textures, Shaders, Models, etc.) type: chore Formatting, minor refactorization type: docs

Comments

@wpumacay
Copy link
Owner

wpumacay commented May 24, 2023

Description

These are a few missing pieces in the current implementation of the shader and program objects:

  • Replace the usage of std::unique_ptr in favor of std::shared_ptr. This is required as we'll be sharing ownership between the user and containers that have accessors in Python land.
  • Add missing manual documentation (.rst) and autogenerated from docstrings (Sphinx).

Tasks

  • Use shared_ptr instead of unique_ptr
  • Add examples of usage in the docs (.rst)
  • Add API reference from generated docs using Sphinx.
@wpumacay wpumacay converted this from a draft issue May 24, 2023
@wpumacay wpumacay self-assigned this May 24, 2023
@wpumacay wpumacay added component: assets Related to assets management (e.g. Textures, Shaders, Models, etc.) type: chore Formatting, minor refactorization type: docs labels May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: assets Related to assets management (e.g. Textures, Shaders, Models, etc.) type: chore Formatting, minor refactorization type: docs
Projects
Status: Todo
Development

No branches or pull requests

1 participant