Address review comments: fix variable names.

wxyxinyu · Jun 20, 2016 · 2a6764b · 2a6764b
1 parent 4cd508e
commit 2a6764b
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/extensions/objects/templates/SetOfHtmlStringEditor.js b/extensions/objects/templates/SetOfHtmlStringEditor.js
@@ -48,11 +48,11 @@ oppia.directive('setOfHtmlStringEditor', [
 
       // The following function is necessary to insert elements into the answer
       // groups for the Item Selection Widget.
-      $scope.toggleSelection = function(index) {
-        var choiceHtml = $scope.choices[index].id;
-        var searchIndex = $scope.$parent.value.indexOf(choiceHtml);
-        if (searchIndex > -1) {
-          $scope.$parent.value.splice(searchIndex, 1);
+      $scope.toggleSelection = function(choiceListIndex) {
+        var choiceHtml = $scope.choices[choiceListIndex].id;
+        var selectedChoicesIndex = $scope.$parent.value.indexOf(choiceHtml);
+        if (selectedChoicesIndex > -1) {
+          $scope.$parent.value.splice(selectedChoicesIndex, 1);
         } else {
           $scope.$parent.value.push(choiceHtml);
         }