Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: separate app and lib configs #112

Merged
merged 3 commits into from
Jun 25, 2024
Merged

build: separate app and lib configs #112

merged 3 commits into from
Jun 25, 2024

Conversation

tpluscode
Copy link
Contributor

The lib mode did not work well for the GiHub Pages deployment. Hence, I separated the builds so that web deployment is standard vite build and the NPM package will be the UMD we had until now

@tpluscode tpluscode requested a review from ludovicm67 June 25, 2024 09:10
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1f0d020

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ludovicm67
ludovicm67 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@ludovicm67 ludovicm67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks a lot for the trick! LGTM 👍

@ludovicm67 ludovicm67 mentioned this pull request Jun 25, 2024
Closed
@tpluscode tpluscode merged commit 8c8d870 into main Jun 25, 2024
4 checks passed
@tpluscode tpluscode deleted the separate-build branch June 25, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludovicm67 ludovicm67 ludovicm67 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpluscode @ludovicm67